-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cdk): Pass all global flags via env variables #993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afiune
force-pushed
the
afiune/ALLY-1243/afiune/cdk-global-flags
branch
from
October 31, 2022 16:09
1a4bd71
to
4634212
Compare
hazedav
reviewed
Oct 31, 2022
@afiune , I noticed that the removal of global flags has broken
I had integration tests for this which passed on 0.44.0...Thoughts? |
@hazedav amazing catch!!! We should pass that flag to the component!!! 🤦🏽 Fixing now |
@afiune , I tested your change w/ my component and it's looking salad:
|
hazedav
approved these changes
Nov 1, 2022
afiune
force-pushed
the
afiune/ALLY-1243/afiune/cdk-global-flags
branch
from
November 1, 2022 22:53
6a81b70
to
0581a7a
Compare
We were not passing a number of global flags via environment variables, this change adds them all. Signed-off-by: Salim Afiune Maya <[email protected]>
Signed-off-by: Salim Afiune Maya <[email protected]>
Signed-off-by: Salim Afiune Maya <[email protected]>
Signed-off-by: Salim Afiune Maya <[email protected]>
afiune
force-pushed
the
afiune/ALLY-1243/afiune/cdk-global-flags
branch
from
November 2, 2022 04:54
0581a7a
to
a636fca
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We were not passing a number of global flags via environment variables, this change adds them all.
Signed-off-by: Salim Afiune Maya [email protected]
How did you test this change?
Ran CDK commands
Issue
https://lacework.atlassian.net/browse/ALLY-1243