Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: remove deprecated v1 API #120

Merged
merged 2 commits into from
Jun 29, 2023

Conversation

jon-stewart
Copy link
Contributor

@jon-stewart jon-stewart commented Jun 15, 2023

Description

Testing

tests/api/v2/test_contract_info.py has been failing on main branch for a while now. Known bug in api-server so marking the test as flaky.

> poetry run pytest -m "not ci_exempt and not flaky_test" tests/api/v2
===================================================================================== test session starts =====================================================================================
platform darwin -- Python 3.7.16, pytest-7.2.2, pluggy-1.0.0
rootdir: /Users/j0n/Workspace/Lacework/python-sdk, configfile: pytest.ini
plugins: rerunfailures-11.1.2, lazy-fixture-0.6.3
collected 185 items / 35 deselected / 150 selected
chore: mark test_contract_info as flakey

tests/api/v2/test_activities.py ..                                                                                                                                                      [  1%]
tests/api/v2/test_agent_access_tokens.py .......                                                                                                                                        [  6%]
tests/api/v2/test_agent_info.py ..                                                                                                                                                      [  7%]
tests/api/v2/test_alert_channels.py ................                                                                                                                                    [ 18%]
tests/api/v2/test_alert_profiles.py .......                                                                                                                                             [ 22%]
tests/api/v2/test_alert_rules.py .......                                                                                                                                                [ 27%]
tests/api/v2/test_audit_logs.py ....                                                                                                                                                    [ 30%]
tests/api/v2/test_cloud_accounts.py .....                                                                                                                                               [ 33%]
tests/api/v2/test_cloud_activities.py ........                                                                                                                                          [ 38%]
tests/api/v2/test_configs.py .......                                                                                                                                                    [ 43%]
tests/api/v2/test_container_registries.py ........                                                                                                                                      [ 48%]
tests/api/v2/test_contract_info.py .                                                                                                                                                    [ 49%]
tests/api/v2/test_datasources.py ...                                                                                                                                                    [ 51%]
tests/api/v2/test_entities.py ..                                                                                                                                                        [ 52%]
tests/api/v2/test_inventory.py ........                                                                                                                                                 [ 58%]
chore: mark test_contract_info as flaky_test
tests/api/v2/test_organization_info.py ..                                                                                                                                               [ 59%]
tests/api/v2/test_policy_exceptions.py .......                                                                                                                                          [ 64%]
tests/api/v2/test_report_rules.py .......                                                                                                                                               [ 68%]
tests/api/v2/test_reports.py ..                                                                                                                                                         [ 70%]
tests/api/v2/test_resource_groups.py .......                                                                                                                                            [ 74%]
tests/api/v2/test_schemas.py ....                                                                                                                                                       [ 77%]
tests/api/v2/test_team_users.py .......                                                                                                                                                 [ 82%]
tests/api/v2/test_user_groups.py .....                                                                                                                                                  [ 85%]
tests/api/v2/test_user_profile.py ..                                                                                                                                                    [ 86%]
tests/api/v2/test_vulnerabilities.py ......                                                                                                                                             [ 90%]
tests/api/v2/test_vulnerability_exceptions.py .......                                                                                                                                   [ 95%]
tests/api/v2/test_vulnerability_policies.py .......                                                                                                                                     [100%]

======================================================================= 150 passed, 35 deselected in 287.12s (0:04:47) =======================================================================

Link

https://lacework.atlassian.net/browse/GROW-1529

@jon-stewart jon-stewart self-assigned this Jun 15, 2023
@jon-stewart jon-stewart requested a review from a team as a code owner June 15, 2023 08:55
@jon-stewart jon-stewart requested a review from kiddinn June 15, 2023 09:05
@jon-stewart
Copy link
Contributor Author

Closes #88

Copy link
Contributor

@afiune afiune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has to be released as a major version bump.

@jon-stewart jon-stewart merged commit 9c76778 into main Jun 29, 2023
@jon-stewart jon-stewart deleted the jon-stewart/GROW-1529/remove-v1-api branch June 29, 2023 08:52
Copy link
Contributor

@kiddinn kiddinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants