Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update and lint all docstrings #140

Merged
merged 5 commits into from
Jan 8, 2024

Conversation

tmac1973
Copy link
Contributor

@tmac1973 tmac1973 commented Jan 5, 2024

Summary:

All docstrings are now updated to google docstring format and pass linting with Ruff.

Testing:

Linting and all tests passed.

If you want to see the results and not just the source run "poetry run poe docs" to generate the documentation and open the "docs/html/index.html" file.

Issue:

https://lacework.atlassian.net/browse/GROW-2623

Incremental work to reformat, rewrite, and correct docstrings for
consumption by Sphinx autodoc

Signed-off-by: Timothy MacDonald <[email protected]>
Signed-off-by: Timothy MacDonald <[email protected]>
@tmac1973 tmac1973 requested a review from a team as a code owner January 5, 2024 23:40
Copy link
Contributor

@jon-stewart jon-stewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvements, but I have a few questions.

tests/api/v2/test_activities.py Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
laceworksdk/http_session.py Show resolved Hide resolved
laceworksdk/http_session.py Show resolved Hide resolved
laceworksdk/api/v2/events.py Show resolved Hide resolved
Signed-off-by: Timothy MacDonald <[email protected]>
@tmac1973 tmac1973 merged commit cc50f0f into main Jan 8, 2024
8 checks passed
@tmac1973 tmac1973 deleted the tmacdonald/GROW-2623/update-docstrings branch January 8, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants