Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added an IP accessor with a reverse DNS function. #51

Merged
merged 1 commit into from
Jan 6, 2022
Merged

Added an IP accessor with a reverse DNS function. #51

merged 1 commit into from
Jan 6, 2022

Conversation

kiddinn
Copy link
Contributor

@kiddinn kiddinn commented Jan 6, 2022

This PR adds a simple class that adds an IP accessor to dataframes in the notebook environment.

They can be accessed with df.my_column.ip.X

This PR only implements a single accessor, reverse_dns can be used:

my_frame['reverse_host'] = my_frame['ip_address'].ip.reverse_dns()

@kiddinn kiddinn requested a review from heidark January 6, 2022 13:38
heidark
heidark approved these changes Jan 6, 2022
View reviewed changes
Copy link

@heidark heidark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kiddinn kiddinn merged commit 4664104 into master Jan 6, 2022
@kiddinn kiddinn deleted the ip_accessor branch January 6, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heidark heidark heidark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kiddinn @heidark