Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a simple Mitre Att&ck class as well as a helper for Alerts API. #57

Merged
merged 4 commits into from
Feb 4, 2022
Merged

Added a simple Mitre Att&ck class as well as a helper for Alerts API. #57

merged 4 commits into from
Feb 4, 2022

Conversation

kiddinn
Copy link
Contributor

@kiddinn kiddinn commented Feb 4, 2022 •
edited
Loading

This PR adds few things

  1. Minor bug fix in the query_builder after changes from pagination support
  2. New handling of data frame creation for the Alerts API
  3. A class/client to get Mitre Att&ck information.
  4. A helper that combines Alert API call and Mitre Att&ck information

@kiddinn kiddinn marked this pull request as ready for review February 4, 2022 15:58
alannix-lw
alannix-lw approved these changes Feb 4, 2022
View reviewed changes
Copy link
Contributor

@alannix-lw alannix-lw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kiddinn kiddinn merged commit f541450 into master Feb 4, 2022
@kiddinn kiddinn deleted the mitre branch February 4, 2022 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alannix-lw alannix-lw alannix-lw approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kiddinn @alannix-lw