Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) fixed and issue for subclasses containing API calls in Jupyter notebook #87

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

kiddinn
Copy link
Contributor

@kiddinn kiddinn commented Sep 1, 2022

Fixed an issue in API V2 where APIs are subclasses of other classes, eg .activities.dns, etc... this PR makes sure to traverse the sub classes as well, one layer deeper to register the API wrapper accordingly.

@kiddinn kiddinn merged commit 9325984 into main Sep 1, 2022
@kiddinn kiddinn deleted the fix_sub branch September 1, 2022 14:40
@alannix-lw alannix-lw added the bug Something isn't working label Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants