Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) a bug in TS API client prevents the notebook from loading. #89

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

kiddinn
Copy link
Contributor

@kiddinn kiddinn commented Oct 21, 2022

The TS API client has not yet upgraded the now deprecated OOB flow in Oauth, causing it to fail when attempting to import, and therefore having cascading effects on the jupyter notebook environment (which loads the TS client as part of other libraries)... disabling the dependencies for now

TS bug: google/timesketch#2388

@kiddinn kiddinn requested a review from heidark October 21, 2022 13:59
Copy link

@heidark heidark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@kiddinn kiddinn added the bug Something isn't working label Oct 21, 2022
Copy link
Contributor

@alannix-lw alannix-lw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kiddinn kiddinn merged commit 79d4f6b into main Oct 21, 2022
@kiddinn kiddinn deleted the fix branch October 21, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants