fix integration test for org acct

lacework · May 25, 2023 · cb40e0d · cb40e0d
1 parent c4f1626
commit cb40e0d
Show file tree

Hide file tree

Showing 6 changed files with 209 additions and 389 deletions.
diff --git a/examples/resource_lacework_integration_aws_org_agentless_scanning/main.tf b/examples/resource_lacework_integration_aws_org_agentless_scanning/main.tf
@@ -11,7 +11,6 @@ provider "lacework" {
 }
 
 resource "lacework_integration_aws_org_agentless_scanning" "example" {
-
   name                      = var.name
   query_text                = var.query_text
   scan_frequency            = 24

diff --git a/examples/resource_lacework_integration_gcp_agentless_scanning/main.tf b/examples/resource_lacework_integration_gcp_agentless_scanning/main.tf
@@ -66,10 +66,6 @@ variable "filter_list" {
   default = ["proj1", "proj2"]
 }
 
-variable "org_account_mappings" {
-
-}
-
 resource "lacework_integration_gcp_agentless_scanning" "example" {
   name = var.integration_name
   credentials {
@@ -88,20 +84,6 @@ resource "lacework_integration_gcp_agentless_scanning" "example" {
   scan_host_vulnerabilities = true
   query_text = var.query_text
   filter_list = var.filter_list
-
-  org_account_mappings {
-    default_lacework_account = "lw_account_1"
-
-    mapping {
-      lacework_account = "lw_account_2"
-      gcp_projects     = ["234556677", "774564564"]
-    }
-
-    mapping {
-      lacework_account = "lw_account_3"
-      gcp_projects     = ["553453453", "934534535"]
-    }
-  }
 }
 
 output "name" {

diff --git a/integration/resource_lacework_integration_aws_org_agentless_scanning_test.go b/integration/resource_lacework_integration_aws_org_agentless_scanning_test.go
@@ -15,10 +15,6 @@ import (
 // nolint
 
 func TestIntegrationAwsOrgAgentlessScanningLog(t *testing.T) {
-	// awsCreds, err := awsLoadDefaultCredentials()
-	// if err != nil {
-	// 	println("Error when getting awscreds: ", err)
-	// }
 	terraformOptions := terraform.WithDefaultRetryableErrors(t, &terraform.Options{
 		TerraformDir: "../examples/resource_lacework_integration_aws_org_agentless_scanning",
 		Vars: map[string]interface{}{
@@ -27,6 +23,8 @@ func TestIntegrationAwsOrgAgentlessScanningLog(t *testing.T) {
 			"scanning_account":   "259832199722",
 			"management_account": "259832199722",
 			"monitored_accounts": []string{"327958430571", "460445523461"},
+			"role_arn":           "arn:aws:iam::249446771485:role/lacework-iam-example-role",
+			"external_id":        "12345",
 			"org_account_mappings": []map[string]interface{}{
 				{
 					"default_lacework_account": "agentless",
@@ -38,7 +36,8 @@ func TestIntegrationAwsOrgAgentlessScanningLog(t *testing.T) {
 					},
 				},
 			},
-		}})
+		},
+	})
 
 	defer terraform.Destroy(t, terraformOptions)
 
@@ -62,12 +61,14 @@ func TestIntegrationAwsOrgAgentlessScanningLog(t *testing.T) {
 		"scanning_account":   "259832199722",
 		"management_account": "259832199722",
 		"monitored_accounts": []string{"327958430571", "460445523461"},
+		"role_arn":           "arn:aws:iam::249446771485:role/lacework-iam-example-role",
+		"external_id":        "12345678",
 		"org_account_mappings": []map[string]interface{}{
 			{
 				"default_lacework_account": "agentless",
 				"integration_mappings": []map[string]interface{}{
 					{
-						"lacework_account": "sub1",
+						"lacework_account": "sub2",
 						"aws_accounts":     []string{"327958430571"},
 					},
 				},