Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(LINK-3033): set query_id when importing lacework_resource_query #654

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

PengyuanZhao
Copy link
Contributor

Issue: https://lacework.atlassian.net/browse/LINK-3033

Description:
The issue is when importing lacework_resource_query, the query_id is not set which causes a state drift. This PR fixes it.

@PengyuanZhao PengyuanZhao requested a review from a team as a code owner September 10, 2024 15:48
@PengyuanZhao PengyuanZhao requested review from marktabry, jeffreynglw, petrlw and nixc0 and removed request for a team September 10, 2024 15:48
Copy link
Contributor

@leijin-lw leijin-lw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good. However, there are failing tests with resource group tests. We can disable the rgv1 tests

@PengyuanZhao PengyuanZhao merged commit 40584dc into main Sep 10, 2024
7 of 8 checks passed
@PengyuanZhao PengyuanZhao deleted the pengyuan/LINK-3033 branch September 10, 2024 19:13
@lacework-releng lacework-releng mentioned this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants