Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding geography author service. #1

Open
wants to merge 11 commits into
base: dev
Choose a base branch
from

Conversation

janedotx
Copy link

@janedotx janedotx commented Mar 5, 2020

Explain pull request

A spec is required for the geography author service.

Is this a breaking change

Yes, geography endpoints that were formerly in policy/policy-author have been moved.

Impacted Spec

Which spec(s) will this pull request impact?

  • geography-author
  • policy-author

@avatarneil
Copy link

What's with the .html files?

@janedotx
Copy link
Author

janedotx commented Mar 5, 2020

What's with the .html files?

Not sure, they were there in policy-author and I figured they'd better come along with the geo stuff.

@janedotx janedotx requested a review from marie-x March 12, 2020 02:54
Copy link

@avatarneil avatarneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still a .html hanging around

geography-author/README.md Outdated Show resolved Hide resolved
geography-author/README.md Outdated Show resolved Hide resolved
geography-author/README.md Outdated Show resolved Hide resolved
@mdurling mdurling removed their request for review April 6, 2022 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants