Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fixed broken ci #1753

Merged
merged 1 commit into from
Nov 29, 2022
Merged

ci: fixed broken ci #1753

merged 1 commit into from
Nov 29, 2022

Conversation

lamweili
Copy link
Contributor

fixed ci failing due to incompatible dev dependencies for Node.js <=12

@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2022

Codecov Report

Merging #1753 (889e90c) into master (0769a85) will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1753      +/-   ##
==========================================
+ Coverage   94.36%   94.42%   +0.06%     
==========================================
  Files          14       14              
  Lines        1135     1148      +13     
==========================================
+ Hits         1071     1084      +13     
  Misses         64       64              
Impacted Files Coverage Δ
src/request-base.js 93.06% <ø> (ø)
src/agent-base.js 100.00% <0.00%> (ø)
src/node/index.js 93.69% <0.00%> (+0.02%) ⬆️
src/utils.js 97.36% <0.00%> (+0.14%) ⬆️
src/node/http2wrapper.js 96.46% <0.00%> (+0.19%) ⬆️
src/node/agent.js 89.13% <0.00%> (+0.49%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lamweili
Copy link
Contributor Author

@titanism, this would fix the broken ci tests by downgrading the mocha.
It is fine because it's a dev dependency anyway.

No release is needed as this doesn't affect the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants