-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do not force-set req.destroyed = true
on abort
#1774
Merged
titanism
merged 1 commit into
ladjs:master
from
afharo:remove-v14-destroy-before-abort-hack
Aug 15, 2023
Merged
fix: do not force-set req.destroyed = true
on abort
#1774
titanism
merged 1 commit into
ladjs:master
from
afharo:remove-v14-destroy-before-abort-hack
Aug 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 14, 2023
v8.1.0 released which fixes this issue, thank you
release notes @ https://github.com/ladjs/superagent/releases/tag/v8.1.0 |
This was referenced Jul 16, 2024
This was referenced Jul 18, 2024
This was referenced Jul 18, 2024
This was referenced Aug 26, 2024
This was referenced Sep 10, 2024
This was referenced Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
this.req.destroyed = true
hack that was added in 8b1923d actually breaks the behavior of 14.0.0.Looking at
v14.0.0
's HTTP client's code, theabort
method internally callsdestroy
.destroy
has an early termination whendestroyed
is alreadytrue
. Settingdestroyed = true
before callingabort()
stops Node.js from internally closing the socket, potentially leading to memory leaks.It also breaks the behavior of
abort()
since Node.js deprecated it in favor ofdestroy()
(as Node.js internally relies ondestroy()
logic to terminate the call.Checklist