Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: replace should with node:assert #1780

Merged
merged 4 commits into from
Aug 27, 2023
Merged

Conversation

jimmywarting
Copy link
Contributor

Part of #1779
Thinking of going trough one file/PR for easier review

Checklist

  • I have ensured my pull request is not behind the main or master branch of the original repository.
  • I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
  • I have written a commit message that passes commitlint linting.
  • I have ensured that my code changes pass linting tests.
  • I have ensured that my code changes pass unit tests.
  • I have described my pull request and the reasons for code changes along with context if necessary.

@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (83e92cb) 94.39% compared to head (0f5b846) 94.39%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1780   +/-   ##
=======================================
  Coverage   94.39%   94.39%           
=======================================
  Files          14       14           
  Lines        1141     1141           
=======================================
  Hits         1077     1077           
  Misses         64       64           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jimmywarting jimmywarting merged commit 0dc80d1 into ladjs:master Aug 27, 2023
6 checks passed
@jimmywarting jimmywarting deleted the agancy branch August 27, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants