-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: replace deprecated url.parse()
with new URL()
#1803
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can you fix merge conflict @alumni ? |
6 tasks
released in v9.0.2 https://github.com/ladjs/superagent/releases/tag/v9.0.2 |
This is possibly a breaking change. Previously, a value like "0.0.0.0" was accepted, while it now errors with "0.0.0.0 is not a valid URL" |
There's a pr open to fix it ;) |
@alumni ah, I was hoping you would review that PR :-D (also, there was an edit in that PR saying it's hard to test) |
This was referenced Jul 16, 2024
This was referenced Jul 18, 2024
This was referenced Jul 18, 2024
This was referenced Aug 28, 2024
This was referenced Sep 8, 2024
This was referenced Sep 16, 2024
This was referenced Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Replaces the other occurrences of
url.parse()
withnew URL()
. Continuation of PR #1802.