fix InformaionScreen scroll issue: height do not match.

laixintao · Oct 21, 2023 · 95e7c2b · 95e7c2b
1 parent ca5bd96
commit 95e7c2b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 15 deletions.
diff --git a/flameshow/pprof_parser/parser.py b/flameshow/pprof_parser/parser.py
@@ -126,7 +126,7 @@ def render_detail(self, sample_index: int, sample_unit: str):
                 )
             frame = frame.parent
 
-        return Text.assemble(*detail), len(detail)
+        return Text.assemble(*detail)
 
     def render_title(self) -> str:
         return self.display_name

diff --git a/flameshow/render/framedetail.py b/flameshow/render/framedetail.py
@@ -340,9 +340,7 @@ def compose(self):
             FrameStatAll(self.frame, self.profile, self.sample_index),
             id="stat-container",
         )
-        content, *_ = self.frame.render_detail(
-            self.sample_index, self.sample_unit
-        )
+        content = self.frame.render_detail(self.sample_index, self.sample_unit)
         span_detail = Static(
             content,
             id="span-detail",
@@ -363,11 +361,8 @@ def _rerender(self):
         except NoMatches:
             return
         span_stack_container.border_title = self.frame.render_title()
-        content, height = self.frame.render_detail(
-            self.sample_index, self.sample_unit
-        )
+        content = self.frame.render_detail(self.sample_index, self.sample_unit)
         span_detail.update(content)
-        span_detail.styles.height = height
 
         try:
             frame_this_widget = self.query_one("FrameStatThis")
@@ -419,14 +414,11 @@ def __init__(
     def compose(self):
         center_text = "Stack detail information"
         yield FlameshowHeader(center_text)
-        content, height = self.frame.render_detail(
-            self.sample_index, self.sample_unit
-        )
+        content = self.frame.render_detail(self.sample_index, self.sample_unit)
         span_detail = Static(
             content,
             id="span-detail",
         )
-        span_detail.styles.height = height
         span_stack_container = VerticalScroll(
             span_detail, id="span-stack-container"
         )
@@ -445,9 +437,7 @@ def watch_sample_index(self, new_sample_index):
     def _rerender(self):
         if not self.composed:
             return
-        content, _ = self.frame.render_detail(
-            self.sample_index, self.sample_unit
-        )
+        content = self.frame.render_detail(self.sample_index, self.sample_unit)
         try:
             span_detail = self.query_one("#span-detail")
         except NoMatches: