Fix parser in case of symbol contains number with a space #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azat
added a commit
to azat-archive/chdig
that referenced
this pull request
Nov 25, 2023
azat
added a commit
to azat/chdig
that referenced
this pull request
Nov 25, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #67 +/- ##
=======================================
Coverage 94.25% 94.25%
=======================================
Files 17 17
Lines 1183 1183
=======================================
Hits 1115 1115
Misses 68 68 ☔ View full report in Codecov by Sentry. |
|
thanks for the fix, I will add test cases later. ;D |
|
seems ok for your case now, thanks @azat 
released in v1.1.1 along with #66 https://github.com/laixintao/flameshow/releases/tag/v1.1.1 |
azat
added a commit
to azat/chdig
that referenced
this pull request
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example: https://gist.github.com/azat/6f98f6d8cac5fad58e07fd913f9cf4f1