hZookeeper #1
Open
hZookeeper #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kratos7
reviewed
Oct 6, 2016
| @@ -0,0 +1,192 @@ | |||
| #!/usr/bin/env python | |||
There was a problem hiding this comment.
Please follow the author convention as in other hydra projects.
src/case_1/zk_client.py
Outdated
|
|
||
| class ZKPub(HDaemonRepSrv): | ||
| def __init__(self,port,run_data,zk_server_ip): | ||
| self.run_data = run_data |
There was a problem hiding this comment.
Also please add comments to functions for better understanding of the code.
There was a problem hiding this comment.
I have asked him to run pip8 and fix all syntax error. Should be done shortly.
kratos7
reviewed
Oct 6, 2016
README.md
Outdated
|
|
||
| ##Background: | ||
|
|
||
| ###Mesos/Marathon: |
There was a problem hiding this comment.
All of this is some great documentation. I think it is general enough to be put into a separate docs repo/folder under lake-lerna ? or may be move to hHelloWorld.
@sushilks what do you think ?
There was a problem hiding this comment.
yes good idea, it should be moved to hello world.
added 4 space indentation, added comments, made minor changes to the code of case_3, case_2 is still under development
|
@kratos7 Added the 4 space indentation and author convention as I was advised. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the files except the hydra libraries which needs to be added as submodule. Need to make few changes to case_2 in it. Case_1 and Case_3 works fine.