impl Responder for actix-web framework #136
Conversation
|
If/when this looks good, I can write something up for the book https://github.com/lfairy/maud-book |
It looks similar to the Rocket implementation, and functionally is also similar: a syncronous response for PreEscaped<String> Refs lambda-fairy#135
anxiousmodernman
force-pushed
the
actix_web_feature
branch
from
ff86aea
to
5f608c7
Compare
|
Ah the infamous "cannot link ring" more than once. My understanding is that we need separate test builds for separate features. Bummer. Hopefully that gets fixed this year. Update I added that in, but I don't know if it's acceptable. |
.travis.yml
Outdated
| - cargo test --all --all-features | ||
| - cargo test --all --features="iron" | ||
| - cargo test --all --features="rocket" | ||
| - cargo test --all --features="actix-web" |
There was a problem hiding this comment.
Can these lines use cargo build instead? With one cargo test --all at the end.
Since the web framework integrations aren't covered by the test suite, we can avoid clutter by only running the tests once.
maud/src/lib.rs
Outdated
| impl Responder for PreEscaped<String> { | ||
| type Item = HttpResponse; | ||
| type Error = Error; | ||
| fn respond_to<String>(self, _req: &HttpRequest<String>) -> Result<Self::Item, Self::Error> { |
There was a problem hiding this comment.
This is better written as
fn respond_to<S>(self, _req: &HttpRequest<S>) -> ...to avoid confusion with the built-in String type
Compiling rocket and actix-web together presents problems, since ring - a native dependency - cannot have more than one version linked.
anxiousmodernman
force-pushed
the
actix_web_feature
branch
from
5474bd9
to
9d9fe5b
Compare
|
@lfairy Can you merge this into master now? Because I use same implementation locally :) |
|
LGTM, thanks! |
It looks similar to the Rocket implementation, and functionally is also similar:
a syncronous response for PreEscaped
Refs #135