Change symbology #31
Merged
Change symbology #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| let r = R("pinkie "); | ||
| html!(s, ^r).unwrap(); | ||
| html!(s, ^r).unwrap(); | ||
| // R is not-Copyable so this shows that it will auto-ref splice arguments that implement Render. |
There was a problem hiding this comment.
Here's the test showing that the compiler auto-refs the spliced values.
Nemo157
force-pushed
the
change-symbology
branch
from
4d6bf75
to
3938739
Compare
|
👍 for using trait auto-ref. I'll have to disagree on removing the sigil from The rest of the patch looks good, so I'll be happy to merge once this is addressed. |
|
Ah, yep, I did wonder why it would be needed, but XML support makes sense. I'll add it back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$->^and#->@.#else(I guess this could break using an element calledelse, but who's gonna do that?)Fixes #21, #24 and #26.