Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update axum-core depedency to 0.2 #337

Merged
merged 3 commits into from
Apr 12, 2022
Merged

Conversation

CBenoit
Copy link
Contributor

@CBenoit CBenoit commented Apr 3, 2022

Hi! Just updating optional dependency axum-core
(Thanks for the great crate!)

@CBenoit
Copy link
Contributor Author

CBenoit commented Apr 3, 2022

I’m not sure why the "Examples" job is failing

@lambda-fairy
Copy link
Owner

I’m not sure why the "Examples" job is failing

Ah, that will be the doctest crate. I've fixed it myself.

Copy link
Owner

@lambda-fairy lambda-fairy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, thanks!

Would you like to update the changelog as well? Happy to merge once that's done.

@CBenoit
Copy link
Contributor Author

CBenoit commented Apr 11, 2022

Thank you! I updated the changelog as requested. I merged with the other axum-related entry because there was no new version in between rendering the note about axum-core v0.1 irrelevant.

Cheers!

@lambda-fairy
Copy link
Owner

Good call. Thanks again!

@lambda-fairy lambda-fairy merged commit d05bcba into lambda-fairy:main Apr 12, 2022
lambda-fairy added a commit that referenced this pull request Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants