Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure data readers are initialized before running cloverage #6

Merged
merged 2 commits into from
Sep 25, 2019

Conversation

skuro
Copy link
Contributor

@skuro skuro commented Sep 25, 2019

Similar to what was already done for lein-cloverage,
data readers need to be evaluated before before running cloverage otherwise
custom tagged literals will result in errors such as (using honeysql):

No reader function for tag sql/call.

Similar to [`lein-cloverage`](cloverage/cloverage#255),
data readers need to be evaluated before before running cloverage otherwise
custom tagged literals will result in errors such as (using `honeysql`):

```
No reader function for tag sql/call.
```
@plexus plexus merged commit aadf134 into lambdaisland:master Sep 25, 2019
@plexus
Copy link
Member

plexus commented Sep 25, 2019

thanks, can you also update the CHANGELOG please?

skuro added a commit to skuro/kaocha-cloverage that referenced this pull request Sep 25, 2019
plexus added a commit that referenced this pull request Sep 25, 2019
Changelog updated to reflect changes in PR #6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants