Reveal doesn't work with slach (/) separated path on Windows

[TisnKu]

Thanks for this plugin. I recently switched from nerdtree, it is so much faster.

Here is the issue. If I open a file via Fern explorer or Telescope search, then I can trigger Fern . -reveal=% -drawer -toggle to reveal current file. However, if the buffer is opened via diffview, then reveal won't work, it will always open the root directory and focus the root folder.

Steps to open a buffer via diffview:

1. Setup up the plugin: use "sindrets/diffview.nvim"
2. Open a git project and edit something
3. Run :DiffviewOpen master to diff against master branch
4. Press gf to go to selected file for editing
5. In current buffer try to trigger Fern command to reveal it in directory

[lambdalisue]

What the value of expand('%') on the buffer opened via diffview? Fern use that value to determine what the actual file.

You can check it by

:echomsg expand('%')

On the buffer opened via diffview.

[TisnKu]

@lambdalisue It shows the file path correctly.

[TisnKu]

Nerdtree works with this situation though. Here is the link to the implementation: https://github.com/preservim/nerdtree/blob/c46e12a886b4a6618a9e834c90f6245952567115/autoload/nerdtree/ui_glue.vim#L296

[lambdalisue]

I could not reproduce the issue. Please make a minimal vimrc.

CleanShot.2023-07-06.at.19.05.48.mp4

[TisnKu]

@lambdalisue Sorry for not clear enough about the repro steps. As long as you open the buffer before using diffview to open it, the issue cannot occur. So after git changes, simply reopen vim and use diffview to jump to that file directly.

[lambdalisue]

Could not reproduce.

CleanShot.2023-07-07.at.13.59.36.mp4

[TisnKu]

Here is a minimum init.lua for neovim. I figured out why you cannot repro. The issue exists only on windows powershell and not in wsl2 ubuntu.

vim.g.loaded_netrw = 1
vim.g.loaded_netrwPlugin = 1

-- Plugins
local ensure_packer = function()
  local fn = vim.fn
  local install_path = fn.stdpath("data") .. "/site/pack/packer/start/packer.nvim"
  if fn.empty(fn.glob(install_path)) > 0 then
    fn.system({ "git", "clone", "--depth", "1", "https://github.com/wbthomason/packer.nvim", install_path })
    vim.cmd([[packadd packer.nvim]])
    return true
  end
  return false
end

local packer_bootstrap = ensure_packer()

-- Plugins
require("packer").startup(function(use)
  use("wbthomason/packer.nvim")

  use("lambdalisue/fern.vim")
  use("preservim/nerdtree")
  use { 'sindrets/diffview.nvim', requires = { 'nvim-lua/plenary.nvim' },
    config = function()
      require('diffview').setup()
    end
  }
  if packer_bootstrap then
    require("packer").sync()
  end
end)
-- End plugins

[lambdalisue]

As long as you open the buffer before using diffview to open it, the issue cannot occur.

---

I figured out why you cannot repro. The issue exists only on windows powershell and not in wsl2 ubuntu.

Then, could you find the difference of expand('%') between before and after on windows powershell?

[TisnKu]

@lambdalisue There is a difference!
Using diffview to open a buffer shows the absolute path:

Directly open a buffer shows relative path:

[TisnKu]

The same difference exists on WSL2 but that does not seem to be a problem.

[lambdalisue]

So diffview opens a path separated by slash (/) even on windows but the proper path should be backslash (\) right?

[TisnKu]

@lambdalisue Exactly. Interesting that the buffer is opened succssfully with this path and NerdTree can still locate the file.

[lambdalisue]

@TisnKu I'm sorry for late. While I could not reproduce the situation, I'm not sure if this change fixes your issue but could you try #505 ?