Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix immutability of fern#internal#node#expand() function #482

Merged
merged 5 commits into from
Aug 26, 2023
Merged

Fix immutability of fern#internal#node#expand() function #482

merged 5 commits into from
Aug 26, 2023

Commits on Aug 26, 2023

  1. Simplify node tests

    @lambdalisue
    lambdalisue committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    f4b956e View commit details
    Browse the repository at this point in the history

  2. Add immutability tests of expand/collapse

    @lambdalisue
    lambdalisue committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    3ff5513 View commit details
    Browse the repository at this point in the history

  3. Fix immutability of expand

    @lambdalisue
    lambdalisue committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    68ed0fa View commit details
    Browse the repository at this point in the history

  4. Ensure that the node is collapsed prior to reveal

    @lambdalisue
    lambdalisue committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    9e491f6 View commit details
    Browse the repository at this point in the history

  5. Clarify the reason why we need to deepcopy cached children

    @lambdalisue
    lambdalisue committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    f6733bd View commit details
    Browse the repository at this point in the history