Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Vim prior to 8.2.5136 to fix CI on macOS #507

Merged
merged 2 commits into from
Oct 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions .github/workflows/neovim.yml
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
name: neovim
name: Neovim

on:
push:
branches:
- main
pull_request:
workflow_dispatch:

jobs:
build:
Expand All @@ -20,16 +21,16 @@ jobs:
- v0.4.4
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- uses: actions/checkout@v4
lambdalisue marked this conversation as resolved.
Show resolved Hide resolved
with:
repository: thinca/vim-themis
path: vim-themis
- uses: thinca/action-setup-vim@v1
- uses: rhysd/action-setup-vim@v1
id: nvim
with:
vim_type: "Neovim"
vim_version: "${{ matrix.version }}"
neovim: true
version: "${{ matrix.version }}"
- name: Run tests
env:
THEMIS_VIM: ${{ steps.nvim.outputs.executable }}
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/reviewdog.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,14 @@ on:
branches:
- main
pull_request:
workflow_dispatch:

jobs:
vimlint:
name: runner / vint
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
lambdalisue marked this conversation as resolved.
Show resolved Hide resolved
- name: vint
uses: reviewdog/action-vint@v1
with:
Expand Down
23 changes: 9 additions & 14 deletions .github/workflows/vim.yml
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@
name: vim
name: Vim

on:
push:
branches:
- main
pull_request:
workflow_dispatch:

jobs:
build:
test:
strategy:
fail-fast: false
matrix:
Expand All @@ -16,25 +17,19 @@ jobs:
- windows-latest
- ubuntu-latest
version:
- head
- v8.2.0716 # Ubuntu 20.10 (2021/02/28)
- v8.1.2269 # Ubuntu 20.04 (2021/02/28)
- nightly
- v8.2.5136 # https://github.com/lambdalisue/vim-fern/issues/506
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- uses: actions/checkout@v4
lambdalisue marked this conversation as resolved.
Show resolved Hide resolved
with:
repository: thinca/vim-themis
path: vim-themis
- uses: thinca/action-setup-vim@v1
- uses: rhysd/action-setup-vim@v1
id: vim
with:
vim_type: "Vim"
vim_version: "${{ matrix.version }}"
# NOTE:
# On Linux, Vim must be built from source to fix `input` issue
# https://github.com/thinca/action-setup-vim/issues/11
download: "${{ (runner.OS == 'Linux' && 'never') || 'available' }}"
version: "${{ matrix.version }}"
- name: Run tests
env:
THEMIS_VIM: ${{ steps.vim.outputs.executable }}
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# 🌿 vim-fern

![Support Vim 8.1.2269 or above](https://img.shields.io/badge/support-Vim%208.1.2269%20or%20above-yellowgreen.svg)
![Support Vim 8.2.5136 or above](https://img.shields.io/badge/support-Vim%208.2.5136%20or%20above-yellowgreen.svg)
![Support Neovim 0.4.4 or above](https://img.shields.io/badge/support-Neovim%200.4.4%20or%20above-yellowgreen.svg)
[![Powered by vital.vim](https://img.shields.io/badge/powered%20by-vital.vim-80273f.svg)](https://github.com/vim-jp/vital.vim)
[![Powered by vital-Whisky](https://img.shields.io/badge/powered%20by-vital--Whisky-80273f.svg)](https://github.com/lambdalisue/vital-Whisky)
Expand Down
4 changes: 2 additions & 2 deletions plugin/fern.vim
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ if !has('nvim') && !has('patch-8.1.0994')
elseif exists('+shellslash') && &shellslash
call s:warn('"shellslash" option is not supported thus fern is disabled.')
finish
elseif !has('nvim') && !has('patch-8.1.2269')
call s:warn('Vim prior to 8.1.2269 is not supported and fern might not work properly.')
elseif !has('nvim') && !has('patch-8.2.5136')
call s:warn('Vim prior to 8.2.5136 is not supported and fern might not work properly.')
elseif has('nvim') && !has('nvim-0.4.4')
call s:warn('Neovim prior to 0.4.4 is not supported and fern might not work properly.')
endif
Expand Down