Log HTTP requests/responses (only non-sensitive data) #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e strings This also considers the privacy/security concerns of **NOT** logging sensitive parameters.
…ble strings This also considers the privacy/security concerns of **NOT** logging sensitive parameters.
Ocramius
force-pushed
the
feature/log-http-responses
branch
from
8114f35
to
1f6df0e
Compare
This failed with lowest PHPUnit versions, which was correct: the test was not precise enough.
|
LGTM 👍 |
As verified by a coverage report, phpdbg is not reporting correct coverage for `array_map()` here, and is skipping coverage for the closure inside both log processors. In turn, that leads to uncovered mutants being reported, but that is not the case.
Squished some mutants in between: the reason why mutants were uncovered is that closures were not being covered at all. Replacing the closures with PHP 8.1 short closure declarations fixes this, working around the coverage issue.
Ocramius
changed the title
|
🚢 as per @cspray's feedback. I applied some coverage improvements too, while I was at it :) |
|
Hmm, the logger doesn't seem to be in use: Ref: https://github.com/Roave/DocbookTool/actions/runs/3084714475/jobs/4987180006#step:4:13 Seems like the logger output doesn't make it to GitHub's STDERR at all? |
|
Ah, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces general logging for:
This can become a bit verbose, but verbosity could be adjusted later on, if needed: for now, we need this to figure out when/if things go wrong during a release, which is more important than clean output.