Deprecating all ::fromArray() methods in in the package
#153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These methods are brittle, badly documented, and very much type-unsafe. The `src/Generator` API is mostly composed of builder objects, and `::fromArray()` is not necessary in it. Please also do not use arbitrary user input, deserialized as array, to generate code: it's a recipe for disaster. Signed-off-by: Marco Pivetta <[email protected]>
The `::fromArray()` API is now deprecated, and we should encourage the usage of a safer API from now on. Signed-off-by: Marco Pivetta <[email protected]>
froschdesign
requested changes
Nov 18, 2022
Co-authored-by: Frank Brückner <[email protected]> Signed-off-by: Marco Pivetta <[email protected]>
Signed-off-by: Marco Pivetta <[email protected]>
|
Hi, will https://docs.laminas.dev/laminas-code/generator/examples/ be updated? |
|
@tyteen4a03 by someone, yes: are you volunteering? 😁 |
|
@Ocramius I'm not sure what is needed from me because it looks like the docs in the repo are updated but the website doesn't render the latest version of the docs. |
|
@tyteen4a03 aha! Thanks for checking: that's indeed for us to find out then /cc @froschdesign |
|
The problem is the build process for the documentation: https://github.com/laminas/laminas-code/actions/workflows/docs-build.yml - but the logs are gone. |
|
@tyteen4a03 Thanks to @Xerkus |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deprecating all
::fromArray()methods in in the packageThese methods are brittle, badly documented, and very much
type-unsafe.
The
src/GeneratorAPI is mostly composed of builder objects,and
::fromArray()is not necessary in it.Please also do not use arbitrary user input, deserialized as
array, to generate code: it's a recipe for disaster.