Provide PHP 8.1 support #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds 8.1 to the PHP constraint - Changes how we replace zend-escaper - Renames "replace" to "conflict" in `composer.json`, and sets the constraint for "zend-escaper" to "*" - Removes laminas-zendframework-bridge requirement - Adds Laminas CI configuration to ignore PHP platform req on PHP 8.1 builds Signed-off-by: Matthew Weier O'Phinney <[email protected]>
|
This patch also resolves #13 |
Ocramius
approved these changes
Sep 2, 2021
Ocramius
requested changes
Sep 2, 2021
In part to ensure that psalm is running with the same version on the CI platform. Signed-off-by: Matthew Weier O'Phinney <[email protected]>
Syntax flagged is valid under PHP 8, which is the only time the symfony/polyfill-mbstring bootstrap80.php file should be loaded. Signed-off-by: Matthew Weier O'Phinney <[email protected]>
Yep - it's a PHP 8-specific symfony/polyfill-mbstring file; it should be excluded from our scans (as it's in the vendor tree), but for some reason is still showing. I updated the baseline so that it gets ignored, and tests are now green. |
Ocramius
reviewed
Sep 2, 2021
Ocramius
approved these changes
Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch provides PHP 8.1 support, by making the following changes:
composer.json, and sets the constraint for "zend-escaper" to "*"Fixes #13