Remove dev dependency on laminas/laminas-cache-storage-deprecated-factory #142
Conversation
ramchale
force-pushed
the
remove-laminas-cache-storage-deprecated-factory
branch
from
a2d4085
to
65480f1
Compare
…tory Signed-off-by: ramchale <[email protected]>
ramchale
force-pushed
the
remove-laminas-cache-storage-deprecated-factory
branch
from
65480f1
to
93a7418
Compare
There was a problem hiding this comment.
Overall, not sure about this change.
Effectively, we've just dropped a dev dependency and now have an untested code path that imports symbols not defined as hard dependencies.
The undefined deps are of course not your fault 😅, however, I'm preferring the runtime deprecation of the cache option as mentioned in #134 with the addition of new tests to cover the deprecation notice.
|
No worries. Thanks for taking a look. I'll see how the issue conversation goes, and potentially submit a PR based on the outcome of that. |
laminas-cache-storage-deprecated-factory was created precisely for this component, among others. |
Description
laminas/laminas-cache-storage-deprecated-factory states "This factory will not provide support for laminas-cache v4+ and is only meant to be used as a temporary solution in combination with other laminas components."
Continued use is likely to make future maintenance of this package difficult
While it is used in one code path in Translator, as it is not a non-dev dependency I think it's safe to assume anyone using this functionality has it listed as one of their dependencies