Attachments with longs names are not being processed #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, Laminas\Mail successfully identifies filenames longer than 78 chars (RFC 2822) and successfully splits them into multiple variables in \Laminas\Mail\Header\ContentDisposition::getFieldValue(). However, the multiple variables do not get recognized in Laminas\Mime\Decode::splitHeaderField() due to this check strcasecmp($name, $wantedPart) i.e. it compares "filename*0" with "filename". To reproduce, try to process an email with an attachment with long name, for example "This_______________________________________________________is____________________long__________________________________name.txt" Signed-off-by: Ralev93 <[email protected]>
Ocramius
requested changes
Jun 13, 2022
Ocramius
added
Awaiting Author Updates
Bug
|
@Ralev93 I think this should go against |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Report
Summary
Attachments with filenames, longer than 76 char symbols, are not being processed.
Current behavior
Currently, Laminas\Mail successfully identifies long names and successfully splits them into multiple variables in \Laminas\Mail\Header\ContentDisposition::getFieldValue().
However, the multiple variables do not get recognized in Laminas\Mime\Decode::splitHeaderField() due to this check
strcasecmp($name, $wantedPart)i.e. it compares "filename*0" with "filename"
How to reproduce
Try to process an email with an attachment with long name, for example
"This_______________________________________________________is____________________long__________________________________name.txt"
Expected behavior
It should not compare with strcasecmp, but rather with a regex. Then if it is a multiple value, it should concatenate the values