Drop ModuleRouteListener support #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocramius
approved these changes
Jun 6, 2022
Xerkus
force-pushed
the
feature/drop-module-route-listener
branch
from
3fd6655
to
ed64678
Compare
Signed-off-by: Aleksei <[email protected]>
Signed-off-by: Aleksei Khudiakov <[email protected]>
Xerkus
force-pushed
the
feature/drop-module-route-listener
branch
from
ed64678
to
e197f40
Compare
gsteel
added a commit
to laminas/laminas-mvc-view
that referenced
this pull request
Aug 22, 2022
gsteel
added a commit
to laminas/laminas-mvc-view
that referenced
this pull request
Nov 9, 2022
Ref: laminas/laminas-mvc#123 Signed-off-by: George Steel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ModuleRouteListener was initially provided as a way to map
:controllerin route to namespaced controller. It was also useful for Zend Framework 1 users migrating their codebases.This listener was either never enabled by default or disabled fairly soon. We no longer recommend using
:controlleras an url placeholder and suggest users to declare route controllers explicitly.Since this listener was never enabled by default, users do not expect to encounter
MODULE_NAMESPACEin route match and do not account for it when using or changingcontrollerparameter.This PR drops the support for
ModuleRouteListener::MODULE_NAMESPACEentirely and drops the listener itself.Accompanied deprecation PR would be opened against 3.x.
I would like to hear if you need this and why you need it