Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce plugin manager static analysis file #204

Merged
merged 13 commits into from
Mar 2, 2024
Merged

Introduce plugin manager static analysis file #204

merged 13 commits into from
Mar 2, 2024

Commits on Mar 2, 2024

  1. qa: introduce plugin manager static analysis file 

    Signed-off-by: Maximilian Bösing <[email protected]>
    @boesing
    boesing committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    436bfd4 View commit details
    Browse the repository at this point in the history

  2. qa: add validate as well 

    Signed-off-by: Maximilian Bösing <[email protected]>
    @boesing
    boesing committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    3b3616b View commit details
    Browse the repository at this point in the history

  3. qa: remove test testing invalid usage which is covered by psalm 

    Signed-off-by: Maximilian Bösing <[email protected]>
    @boesing
    boesing committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    bd79d54 View commit details
    Browse the repository at this point in the history

  4. qa: add some more static analysis checks 

    Signed-off-by: Maximilian Bösing <[email protected]>
    @boesing
    boesing committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    ead9df3 View commit details
    Browse the repository at this point in the history

  5. bugfix: add missing template-extends to SimplePluginManager 

    Signed-off-by: Maximilian Bösing <[email protected]>
    @boesing
    boesing committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    961d9be View commit details
    Browse the repository at this point in the history

  6. qa: bump psalm to unreleased version to cover latest changes in upstream 

    Signed-off-by: Maximilian Bösing <[email protected]>
    @boesing
    boesing committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    193a410 View commit details
    Browse the repository at this point in the history

  7. qa: remove lctrs/psalm-psr-container-plugin 

    To enable proper static analysis without side-effects, we are removing the container plugin here to verify provided psalm-types from `ServiceLocatorInterface` and `PluginManagerInterface`

Signed-off-by: Maximilian Bösing <[email protected]>
    @boesing
    boesing committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    a84f4f2 View commit details
    Browse the repository at this point in the history

  8. qa: remove MixedAssignment suppressions as these are now suppressed… 

    … by `psalm.xml`

Due to the way, psalm moves forward, this issue will be removed - most probably with v6.
The reasoning behind this is, that `mixed` is not bad per-se, depending on how it is used.
If a codebase accepts `mixed` in a method (even tho that might be revealing method complexity), that is a absolutely okay and thus, passing `mixed` and esp. assigning `mixed` is absolutely fine in case the following code is accepting mixed and/or the value is narrowed down at some point.

Signed-off-by: Maximilian Bösing <[email protected]>
    @boesing
    boesing committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    2e8dd41 View commit details
    Browse the repository at this point in the history

  9. qa: add missing type-narrowing for `AbstractSingleInstancePluginManag… 

    …er#build`

The `AbstractSingleInstancePluginManager` has to always return an object as thats what it is used for. Therefore, type-narrowing here is absolutely fine and still fits liskov substitution principle.

Signed-off-by: Maximilian Bösing <[email protected]>
    @boesing
    boesing committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    0c3694c View commit details
    Browse the repository at this point in the history

  10. qa: add some more static analysis files regarding plugin managers 

    Signed-off-by: Maximilian Bösing <[email protected]>
    @boesing
    boesing committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    3b4d68b View commit details
    Browse the repository at this point in the history

  11. qa: update psalm to latest stable version 

    Signed-off-by: Maximilian Bösing <[email protected]>
    @boesing
    boesing committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    9fa7191 View commit details
    Browse the repository at this point in the history

  12. qa: ignore `SlevomatCodingStandard.Commenting.InlineDocCommentDeclara… 

    …tion.NoAssignment` for inline var annotation

Signed-off-by: Maximilian Bösing <[email protected]>
    @boesing
    boesing committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    b79a3d4 View commit details
    Browse the repository at this point in the history

  13. qa: remove redundant method implementations 

    These methods were initially introduced to fix psalm issues. These were fixed in one of the more recent versions and thus these methods are redundant as of now.

Signed-off-by: Maximilian Bösing <[email protected]>
    @boesing
    boesing committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    ee7ab4e View commit details
    Browse the repository at this point in the history