Backport 4.x #64
Merged
Backport 4.x #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated packages in composer to latest stable version and PHP requirements changed to PHP ^7.1 Updated suggestion in composer.
These methods are not static.
Conflicts: CHANGELOG.md
…olved alias name, and not the alias itself
…tainer Per laminas#239, currently when an argument is type-hinted but has a default value (typically `null`), the factory raises an exception about not being able to retrieve the value from the container. In such cases, we can use the default value for the argument during injection.
Forward port laminas#233 Also brings in changes specific to develop branch.
…d-function Avoid usage of leading `\` on imported functions
…l-State-Changes Adds test for issue laminas#236
All these tests implemented here previously for shared services are moved into separate library so it should be used instead.
…private constructors
update exception messages
Fix travis build : cs fixes
Previously, the imports were _mostly_ alphabetized. However, with the switch to Laminas, the container import was now happening incorrectly with regards to the factory interface. Additionally, it makes sense to alphabetize to ensure we follow our own CS. This patch updates the factory generation code to alphabetize import statements before injecting them in the template. Signed-off-by: Matthew Weier O'Phinney <[email protected]>
Signed-off-by: Abdul Malik Ikhsan <[email protected]>
Signed-off-by: Matthew Weier O'Phinney <[email protected]>
…oxy-manager` to use `laminas` equivalent of `zend-code` Signed-off-by: Maximilian Bösing <[email protected]>
Signed-off-by: Maximilian Bösing <[email protected]>
…ave 7.4 compatibility Signed-off-by: Maximilian Bösing <[email protected]>
… aswell as `laminas/laminas-code` less than `3.3.1` Signed-off-by: Maximilian Bösing <[email protected]>
snapshotpl
reviewed
Dec 8, 2020
`composer.lock` is not committed anymore, thus, there is no need for `latest` and `composer update` anymore Signed-off-by: Maximilian Bösing <[email protected]>
- require `composer/package-versions-deprecated` in order to get proper installation on PHP 7.3 and 8.0 - require `phpbench/phpbench` alpha as it supports PHP 8.0 - only ignore platform-requirement for PHP until `composer/proxy-manager` supports PHP 8.0 Signed-off-by: Maximilian Bösing <[email protected]>
…ow_failures` Signed-off-by: Maximilian Bösing <[email protected]>
This was referenced Dec 8, 2020
6 tasks
froschdesign
reviewed
Jan 6, 2021
weierophinney
requested changes
Jan 6, 2021
There was a problem hiding this comment.
Main comments:
- We're bumping the minimum supported PHP version to 7.4. So all NEW methods should have full typehinting in place; this includes closures.
- Add indenting to heredoc/nowdoc definitions (I have a comment on that later).
- Don't switch between
$this->andself::in the tests; it's a lot of noise, and we really need to have a discussion about this in the TSC to decide which one we're going to use going forward. For now, instance usage is consistent with other components, and reduces the size of this patch considerably.
- Add typehints for any new function/method declarations. - Do not use FQ class names; functions in strings do not need qualification. - Indent heredoc/nowdoc declarations. - Provide typehints on closure definitions. - Do not use `self::` in unit tests. Signed-off-by: Matthew Weier O'Phinney <[email protected]>
Signed-off-by: Matthew Weier O'Phinney <[email protected]>
weierophinney
approved these changes
Jan 7, 2021
We're pinned to `~8.0.0`, and nightly targets 8.1. Signed-off-by: Matthew Weier O'Phinney <[email protected]>
weierophinney
force-pushed
the
backport-4.x
branch
from
1d62a77
to
0174747
Compare
In order to get laminas-code versions that work under PHP 8, we need to have an ocramius/proxy-manager version that no longer uses zend-code. That version is 2.11.0. Also, we need to explicitly select a newer version of doctrine/annotations to fix conflicts with phpbench. Signed-off-by: Matthew Weier O'Phinney <[email protected]>
weierophinney
force-pushed
the
backport-4.x
branch
from
0174747
to
b750fac
Compare
Signed-off-by: Maximilian Bösing <[email protected]>
- remove duplicated test - adds typehints Signed-off-by: Maximilian Bösing <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.