-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge release 2.31.0 into 3.0.x #222
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The return type for a template resolver _should_ simply be `string`. Any kind of failure should cause an exception, ideally something like `TemplateNotFound`. All existing resolvers are marked as `@final` and there are several additional deprecations to clean up un-documented behaviour. Signed-off-by: George Steel <[email protected]>
Moves all docs to v2/ in preparation for v3 documentation changes Signed-off-by: George Steel <[email protected]>
Signed-off-by: George Steel <[email protected]>
…g issues Signed-off-by: George Steel <[email protected]>
Collect V2 Docs into a sub-folder
Signed-off-by: George Steel <[email protected]>
Signed-off-by: George Steel <[email protected]>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
… script Signed-off-by: George Steel <[email protected]>
Signed-off-by: George Steel <[email protected]>
Signed-off-by: George Steel <[email protected]>
Lock file maintenance, introduce test case for `templatemap_generator.php`
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…vers Co-authored-by: Frank Brückner <[email protected]> Signed-off-by: George Steel <[email protected]>
Signed-off-by: George Steel <[email protected]>
Initial 'Preparing for v3' docs
Deprecations and type inference improvements for template resolvers
This is to satisfy static code analytic tools like PHPStan and Psalm. Resolves #73 Signed-off-by: func0der <[email protected]>
Add return type hint to ViewModel::getIterator()
Signed-off-by: George Steel <[email protected]>
…ments Minor type inference improvements to ViewModel and ModelInterface
…to-3.0.x_6n8wir0l # Conflicts: # composer.lock # docs/book/v2/helpers/flash-messenger.md # docs/book/v2/helpers/intro.md # mkdocs.yml # psalm-baseline.xml # src/Resolver/TemplatePathStack.php # test/Resolver/TemplatePathStackTest.php
Signed-off-by: George Steel <[email protected]>
gsteel
approved these changes
Oct 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Baseline expanded slightly here because of new deprecations and better type inference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes for 2.31.0
2.31.0
Documentation,Enhancement
renovate
templatemap_generator.php
thanks to @renovate[bot]Documentation
Documentation,Documentation Needed,Enhancement