Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port coverage filter options for packages and files #19727

Merged
merged 6 commits into from
Feb 27, 2024
Merged

Port coverage filter options for packages and files #19727

merged 6 commits into from
Feb 27, 2024

Conversation

KacperFKorban
Copy link
Member

  • Add -coverage-exclude-packages option that excludes packages and classes
    from generating coverage
  • Add -coverage-exclude-files option that excludes files from
    generating coverage

@KacperFKorban KacperFKorban marked this pull request as ready for review February 19, 2024 19:02
@Kordyjan Kordyjan requested a review from sjrd February 21, 2024 10:37
@Kordyjan
Copy link
Contributor

@sjrd will you have a moment to take a look?

@sjrd sjrd assigned KacperFKorban and unassigned sjrd Feb 22, 2024
@KacperFKorban KacperFKorban assigned sjrd and unassigned KacperFKorban Feb 22, 2024
@sjrd sjrd assigned KacperFKorban and unassigned sjrd and TheElectronWill Feb 27, 2024
KacperFKorban and others added 5 commits February 27, 2024 11:02
@KacperFKorban
Port coverage filter options
c1f2022 
- Add `-coverage-exclude-packages` option that excludes packages and classes
  from generating coverage
- Add `-coverage-exclude-files` option that excludes files from
  generating coverage
@KacperFKorban
Add tests for coverage filters
7affcee
@KacperFKorban
Change the -coverage-exclude-classlikes option and its doc
c01baea
@KacperFKorban @TheElectronWill
Update typo in coverageExcludeClasslikes doc
8f375fc 
Co-authored-by: Guillaume Raffin <[email protected]>
@KacperFKorban
Pre compute coverage filter patterns
5223adb
@KacperFKorban KacperFKorban merged commit 18be8d1 into scala:main Feb 27, 2024
19 checks passed
@ckipp01 ckipp01 mentioned this pull request Mar 1, 2024
Closed
@Kordyjan Kordyjan added this to the 3.4.2 milestone Mar 28, 2024
@maslovalex
Copy link

It will be a great addition to 3.3.x LTS.
Excluding generated files from coverage make Scala3 adoption easier when team has quality gates base on coverage.

Any plans to backport this ? (I see this in the Needs Assesment column https://github.com/orgs/lampepfl/projects/6/views/1?filterQuery=coverage)

@KacperFKorban
Copy link
Member Author

@Gedochao @Kordyjan this might be a question for one of you

@WojciechMazur WojciechMazur mentioned this pull request Jul 1, 2024
Merged
WojciechMazur added a commit that referenced this pull request Jul 2, 2024
@WojciechMazur
Backport "Port coverage filter options for packages and files" to LTS (…
56079bf 
…#20941)

Backports #19727 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjrd sjrd sjrd approved these changes

@TheElectronWill TheElectronWill TheElectronWill approved these changes

@ckipp01 ckipp01 Awaiting requested review from ckipp01

Assignees

@KacperFKorban KacperFKorban

Labels
None yet
Projects
None yet
Milestone
3.4.2
Development

Successfully merging this pull request may close these issues.
5 participants
@KacperFKorban @Kordyjan @maslovalex @sjrd @TheElectronWill