feature: Implemented 'exclude' filter functionality for Scala 3 #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR @ivanobulo! Although I think I'm going to hold off on this. Filter support was actually just merged into Scala 3 here. So instead I'd rather support it natively by just ensuring that we're passing in the correct flags to the compiler if Scala 3 is detected. I know this then won't work for older Scala 3 versions, but I'm ok with that, and I'd rather not add in the extra code here. |
|
@ckipp01 DYK if from the linked thread that native support for this feature would start in Scala 3.4.2? |
|
Should be, it's in release notes for 3.4.2-RC1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented file and package exclusion filter support to address #525