Allocated memory for the PFS buffer dynamically. Saves 60 bytes. #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microbit-sam
force-pushed
the
allocate-pf-buffer-dyn
branch
from
f42d1a1
to
abedea7
Compare
|
thanks @microbit-sam. Do you think this is ready to go, or does it need more testing? |
|
I need to test partial flashing still works, running a local instance of MakeCode has changed since I last did it so haven't had time to get it going again I'll add testing to my Monday todo list |
|
ACK - thanks. |
|
Sorry for the delay this week, been testing this afternoon and it's not resetting after flashing. Will update ASAP |
finneyj
reviewed
Nov 23, 2018
| @@ -200,6 +200,11 @@ void MicroBitPartialFlashingService::flashData(uint8_t *data) | |||
|
|
|||
| packetCount++; | |||
|
|
|||
| // Reallocate block | |||
| if(block == NULL) { | |||
| (uint32_t*) malloc(16 * sizeof(uint32_t)); | |||
There was a problem hiding this comment.
Should this be block = .... ???
microbit-sam
commented
Nov 23, 2018
| @@ -200,6 +200,11 @@ void MicroBitPartialFlashingService::flashData(uint8_t *data) | |||
|
|
|||
| packetCount++; | |||
|
|
|||
| // Reallocate block | |||
| if(block == NULL) { | |||
| (uint32_t*) malloc(16 * sizeof(uint32_t)); | |||
There was a problem hiding this comment.
Suggested change
| (uint32_t*) malloc(16 * sizeof(uint32_t)); | |
| block = (uint32_t*) malloc(16 * sizeof(uint32_t)); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please don't merge yet - still need to completely test Partial Flashing
This PR only allocates the large buffer used in partial flashing when it's required