Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make numpy optional pylance dependency #1216

Open
wjones127 opened this issue Sep 5, 2023 · 2 comments
Open

Make numpy optional pylance dependency #1216

wjones127 opened this issue Sep 5, 2023 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers python

Comments

@wjones127
Copy link
Contributor

I don't think it's required, and it adds ~15MB.

@wjones127 wjones127 added enhancement New feature or request good first issue Good for newcomers python labels Sep 5, 2023
@rishabhRsinghvi
Copy link

Hello @wjones127, I would like to take this issue. Thank you.

@jameswu1991
Copy link

jameswu1991 commented Sep 13, 2024

for anyone who may have come across this issue wondering why numpy is locked to <2.0, i want to add a comment to make a cross-reference back to the PR that created the lock:

furthermore, it seems that pyarrow themselves are working with the idea of making numpy dependency optional:

since the pyarrow PR was only merged last week, i'd expect this to be a part of the upcoming pyarrow 18 release. once that is complete, perhaps making numpy dependency optional for pylance would be easier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers python
Projects
None yet
Development

No branches or pull requests

3 participants