GH-25118: [Python] Make NumPy an optional runtime dependency #41904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: Python
awaiting committer review
raulcd
force-pushed
the
GH-25118
branch
2 times, most recently
from
cad9bef
to
bccf733
Compare
There was a problem hiding this comment.
I am a bit concerned about the maintenance effort for the tests and having to remember to add @pytest.mark.numpy everywhere needed.
I am wondering: could we have a nonumpy marker instead, and label a subset of tests we explicitly want to run in the CI build without numpy? (of course, if that become a lot of tests, that will also be unwieldy) But then at least by default we don't have to think about marking it with numpy, and it's only when specifically working on tests for numpy being optional we have to add a marker.
Another idea would be to split certain test files in two where we could have a single marker at the top of the file indicating it's using numpy or not, instead of having to mark each individual test.
Just brainstorming a bit!
github-actions
bot
added
awaiting changes
pitrou
requested changes
Jun 6, 2024
github-actions
bot
added
awaiting change review
pitrou
reviewed
Jun 12, 2024
github-actions
bot
added
awaiting changes
github-actions
bot
added
awaiting change review
raulcd
commented
Jun 20, 2024
github-actions
bot
added
awaiting changes
Co-authored-by: Antoine Pitrou <[email protected]>
Co-authored-by: Joris Van den Bossche <[email protected]>
Co-authored-by: Antoine Pitrou <[email protected]>
Co-authored-by: Antoine Pitrou <[email protected]>
|
@github-actions crossbow submit -g wheel -g python |
pitrou
approved these changes
Sep 2, 2024
|
Revision: 08da867 Submitted crossbow builds: ursacomputing/crossbow @ actions-e575e4ce7c
|
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 9ab9532. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
|
Thanks @raulcd! |
mapleFU
pushed a commit
to mapleFU/arrow
that referenced
this pull request
Sep 3, 2024
…pache#41904) ### Rationale for this change Being able to run pyarrow without requiring numpy. ### What changes are included in this PR? If numpy is not present we are able to import pyarrow and run functionality. A new CI job has been created to run some basic tests without numpy. ### Are these changes tested? Yes via CI. ### Are there any user-facing changes? Yes, NumPy can be removed from the user installation and pyarrow functionality still works * GitHub Issue: apache#25118 Lead-authored-by: Raúl Cumplido <[email protected]> Co-authored-by: Joris Van den Bossche <[email protected]> Co-authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
zanmato1984
pushed a commit
to zanmato1984/arrow
that referenced
this pull request
Sep 6, 2024
…pache#41904) ### Rationale for this change Being able to run pyarrow without requiring numpy. ### What changes are included in this PR? If numpy is not present we are able to import pyarrow and run functionality. A new CI job has been created to run some basic tests without numpy. ### Are these changes tested? Yes via CI. ### Are there any user-facing changes? Yes, NumPy can be removed from the user installation and pyarrow functionality still works * GitHub Issue: apache#25118 Lead-authored-by: Raúl Cumplido <[email protected]> Co-authored-by: Joris Van den Bossche <[email protected]> Co-authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
khwilson
pushed a commit
to khwilson/arrow
that referenced
this pull request
Sep 14, 2024
…pache#41904) ### Rationale for this change Being able to run pyarrow without requiring numpy. ### What changes are included in this PR? If numpy is not present we are able to import pyarrow and run functionality. A new CI job has been created to run some basic tests without numpy. ### Are these changes tested? Yes via CI. ### Are there any user-facing changes? Yes, NumPy can be removed from the user installation and pyarrow functionality still works * GitHub Issue: apache#25118 Lead-authored-by: Raúl Cumplido <[email protected]> Co-authored-by: Joris Van den Bossche <[email protected]> Co-authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Being able to run pyarrow without requiring numpy.
What changes are included in this PR?
If numpy is not present we are able to import pyarrow and run functionality.
A new CI job has been created to run some basic tests without numpy.
Are these changes tested?
Yes via CI.
Are there any user-facing changes?
Yes, NumPy can be removed from the user installation and pyarrow functionality still works