feat: add a cache for dynamodb schema validation #1308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chebbyChefNEQ
force-pushed
the
rmeng/ddb-fix
branch
from
6b68104
to
89d2331
Compare
chebbyChefNEQ
commented
Sep 20, 2023
| @@ -91,6 +101,23 @@ impl DynamoDBExternalManifestStore { | |||
| table_name: &str, | |||
| commiter_name: &str, | |||
| ) -> Result<Arc<dyn ExternalManifestStore>> { | |||
| lazy_static::lazy_static! { | |||
| static ref SANITY_CHECK_CACHE: RwLock<HashSet<String>> = RwLock::new(HashSet::new()); | |||
There was a problem hiding this comment.
I could change this to a Lru Cache, but this is probably fine. It's very unlikly someone uses thousands of different dynamodb table for commit in the same process
wjones127
approved these changes
Sep 20, 2023
chebbyChefNEQ
force-pushed
the
rmeng/ddb-fix
branch
from
89d2331
to
3905c33
Compare
chebbyChefNEQ
force-pushed
the
rmeng/ddb-fix
branch
from
3905c33
to
1f04fde
Compare
eddyxu
pushed a commit
that referenced
this pull request
Sep 29, 2023
Prior to this PR we describe dynamo db table everytime opening a dataset. This is okay when the number of calls to opening a table with dynamodb store is low. As `DescribeTable` has a account level limit of 2,500 RPS, we should avoid repeatedly calling the API. This PR also fixes error formatting for aws sdk errors. AWS sdk error doesn't include the underlaying error unless asked for.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR we describe dynamo db table everytime opening a dataset. This is okay when the number of calls to opening a table with dynamodb store is low. As
DescribeTablehas a account level limit of 2,500 RPS, we should avoid repeatedly calling the API.This PR also fixes error formatting for aws sdk errors. AWS sdk error doesn't include the underlaying error unless asked for.