chore: part 1/N of refactoring vector index into separate crate #1388
Conversation
eddyxu
requested review from
westonpace,
wjones127 and
chebbyChefNEQ
and removed request for
westonpace and
wjones127
| @@ -382,8 +382,8 @@ impl Dataset { | |||
| let m = d.manifest.as_ref(); | |||
| if schema != m.schema { | |||
| return Err(Error::SchemaMismatch { | |||
| original: m.schema.clone(), | |||
There was a problem hiding this comment.
Gonna re-eanble these after we cleanly migrate schema to lance-core
| .await?; | ||
| .await | ||
| .map_err(|e| Error::IO { | ||
| message: format!("dynamodb error: {}", e,), |
There was a problem hiding this comment.
can you keep the source error?
dynamodb formatter hides the read error if we only print {}
There was a problem hiding this comment.
349 | .map_err(|e| Error::IO {
| - binding `e` declared here
350 | message: format!("dynamodb error: {}, source: {:?}", e, e.into_source()),
| -----------------------------------------------^---------------
| | | |
| | | move out of `e` occurs here
| | borrow of `e` occurs here
| borrow later used here
did i do sth wrong here?
There was a problem hiding this comment.
We will have the From<SDKError> for Error back once this code is migrated to lance-core
There was a problem hiding this comment.
I think these changes are good. Will defer to @chebbyChefNEQ on the impact of the dynamo errors. I think the arrow schema error being temporarily disabled is probably fine.
| /// IVF - IVF file partition | ||
| /// | ||
| #[derive(Debug, Clone)] | ||
| pub struct Ivf { |
There was a problem hiding this comment.
This is duplicating the Ivf struct that's in the lance crate right? Or was this supposed to be a move?
There was a problem hiding this comment.
I am going to move the IVF model from lance to here. Wanted to get this in before it becomes too big.
No description provided.