feat: remove tombstones from the IVF remapping process by shrinking the index #1397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plified remap task traits
eddyxu
approved these changes
Oct 12, 2023
westonpace
merged commit f291c74
into
lancedb:feat/remap-indices-on-compaction
15 checks passed
westonpace
added a commit
that referenced
this pull request
Oct 12, 2023
Added the ability to remap IVF/PQ indices. This can be used during compaction to notify the index that row ids have changed. feat: remove tombstones from the IVF remapping process by shrinking the index (#1397) I also simplify the remap tasks a bit by removing some unnecessary traits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also simplify the remap tasks a bit by removing some unnecessary traits.