Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: expose progress on write_fragments and write_dataset #1464

Merged
merged 2 commits into from
Oct 30, 2023
Merged

feat: expose progress on write_fragments and write_dataset #1464

merged 2 commits into from
Oct 30, 2023

Conversation

wjones127
Copy link
Contributor

Closes #1463

@wjones127 wjones127 force-pushed the wjones127/fix-progress branch 2 times, most recently from 03b947c to 031da35 Compare October 26, 2023 01:34
@wjones127 wjones127 marked this pull request as ready for review October 26, 2023 02:22
@wjones127 wjones127 requested a review from eddyxu October 26, 2023 02:22
@wjones127 wjones127 force-pushed the wjones127/fix-progress branch 2 times, most recently from c5f461c to eabe032 Compare October 26, 2023 15:37
eddyxu
eddyxu approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@eddyxu eddyxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wjones127 wjones127 merged commit d874971 into main Oct 30, 2023
15 checks passed
@wjones127 wjones127 deleted the wjones127/fix-progress branch October 30, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddyxu eddyxu eddyxu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

progress hooks aren't called in write_dataset or write_fragments
2 participants
@wjones127 @eddyxu