feat: provide a f32x16 abstraction to make unrolling 256-bit code easier #1495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also update |
eddyxu
requested review from
wjones127,
QianZhu,
westonpace and
chebbyChefNEQ
westonpace
approved these changes
Nov 1, 2023
| @@ -249,4 +498,23 @@ mod tests { | |||
| format!("{:?}", simd_power) | |||
| ); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn test_basic_f32x16_ops() { | |||
There was a problem hiding this comment.
It's probably tedious but given how technical these methods are, it might be a good idea to add tests for all the methods (e.g. add, add assign, sub, etc.)
Comment on lines
+55
to
+72
| let dim = self.len(); | ||
| if dim % 16 == 0 { | ||
| let mut sum = f32x16::zeros(); | ||
| for i in (0..dim).step_by(16) { | ||
| let x = unsafe { f32x16::load_unaligned(self.as_ptr().add(i)) }; | ||
| sum += x * x; | ||
| } | ||
| sum.reduce_sum().sqrt() | ||
| } else if dim % 8 == 0 { | ||
| let mut sum = f32x8::zeros(); | ||
| for i in (0..dim).step_by(8) { | ||
| let x = unsafe { f32x8::load_unaligned(self.as_ptr().add(i)) }; | ||
| sum += x * x; | ||
| } | ||
| sum.reduce_sum().sqrt() | ||
| } else { | ||
| // Fallback to scalar | ||
| return self.iter().map(|v| v * v).sum::<f32>().sqrt(); |
There was a problem hiding this comment.
I like how readable this is (well, readable for SIMD :)
| x2 -= y2; | ||
| sum1.multiply_add(x1, x1); | ||
| sum2.multiply_add(x2, x2); | ||
| let mut x = f32x16::load_unaligned(self.as_ptr().add(i)); |
There was a problem hiding this comment.
do we want to unroll more than twice?
There was a problem hiding this comment.
Yea we can add it later? did not see improvement last time on my CPU tho.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.