Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use caller location in error conversion functions #1510

Merged
merged 1 commit into from
Nov 2, 2023
Merged

feat: use caller location in error conversion functions #1510

merged 1 commit into from
Nov 2, 2023

Conversation

chebbyChefNEQ
Copy link
Contributor

closes #1309

Use #[track_caller] to resolve the caller location in From<SomeError> for Error implementations.

westonpace
westonpace approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@westonpace westonpace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool

@chebbyChefNEQ chebbyChefNEQ merged commit ce61a33 into main Nov 2, 2023
15 checks passed
@chebbyChefNEQ chebbyChefNEQ deleted the rmeng/error-loc branch November 2, 2023 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westonpace westonpace westonpace approved these changes

@eddyxu eddyxu Awaiting requested review from eddyxu

@wjones127 wjones127 Awaiting requested review from wjones127

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

location: location!() in From<SomeError> are not accurate
2 participants
@chebbyChefNEQ @westonpace