feat: make L2 generic to work with all float numbers #1532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddyxu
requested review from
wjones127,
westonpace and
chebbyChefNEQ
and removed request for
wjones127 and
westonpace
rok
reviewed
Nov 7, 2023
| y.chunks_exact(dimension) | ||
| .map(move |v| l2_once::<f32x16, 16>(x, v)), | ||
| ), | ||
| _ => Box::new(y.chunks_exact(dimension).map(|v| Self::l2(x, v))), |
There was a problem hiding this comment.
Will this always resolve correctly?
There was a problem hiding this comment.
We let the caller to make sure y is a batch of centroids. Even the dimension is odd number, y.len() % dimension == 0. We could prob add a debug_assert here.
rok
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.