feat: allow scalar indices to be updated with new data #1576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonpace
force-pushed
the
feat/scalar-index-update
branch
3 times, most recently
from
960294b
to
532c782
Compare
westonpace
force-pushed
the
feat/scalar-index-update
branch
from
532c782
to
47c5137
Compare
wjones127
approved these changes
Nov 16, 2023
Comment on lines
+1125
to
+1126
| let all_data = Arc::new(UnionExec::new(vec![old_input, new_input])); | ||
| let ordered = Arc::new(SortPreservingMergeExec::new(vec![sort_expr], all_data)); |
There was a problem hiding this comment.
Nice use of DataFusion 🔥
There was a problem hiding this comment.
It's a very cool tool
| let index_dir = dataset.indices_dir().child(new_uuid.to_string()); | ||
| let new_store = LanceIndexStore::new((*dataset.object_store).clone(), index_dir); | ||
|
|
||
| index.update(new_data_stream.into(), &new_store).await?; |
There was a problem hiding this comment.
Remind me, why don't we remove old data? Is that a future TODO?
There was a problem hiding this comment.
Hmm...embarrassingly I think it's just because I didn't consider it 😆 I'll add it as a future TODO.
|
Test failure is a known intermittent failure. I will merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Training a scalar index is quick so on update we retrain. We sort the new data and then read in the already sorted old data and train on the merged stream.
Closes #1568