feat: make partition calculation parallel #1625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjones127
reviewed
Nov 17, 2023
rust/lance-index/src/vector/ivf.rs
Outdated
| let chunks = std::cmp::min(num_cpus::get(), num_rows); | ||
|
|
||
| info!( | ||
| "computing parition on {} chunks, out of {} centroids, and {} vectors", |
There was a problem hiding this comment.
Suggested change
| "computing parition on {} chunks, out of {} centroids, and {} vectors", | |
| "computing partition on {} chunks, out of {} centroids, and {} vectors", |
wjones127
reviewed
Nov 17, 2023
rust/lance/src/index/vector/ivf.rs
Outdated
| @@ -714,6 +714,8 @@ pub async fn build_ivf_pq_index( | |||
| vec![], | |||
| None, | |||
| )?; | |||
|
|
|||
| info!("starting to compute partitions for PQ training, sample size"); | |||
There was a problem hiding this comment.
Did you mean to log the sample size or something?
There was a problem hiding this comment.
ah yes, fixing
rok
reviewed
Nov 17, 2023
|
|
||
| info!( | ||
| "computing parition on {} chunks, out of {} centroids, and {} vectors", | ||
| chunks, num_centroids, num_rows, |
There was a problem hiding this comment.
To print as integers instead of floats?
Suggested change
| chunks, num_centroids, num_rows, | |
| chunks as usize, num_centroids as usize, num_rows as usize, |
There was a problem hiding this comment.
added as usize to chunks. the other one are already usize and clippy complains
rok
approved these changes
Nov 17, 2023
chebbyChefNEQ
force-pushed
the
rmeng/fix-index
branch
2 times, most recently
from
8505653
to
e264a21
Compare
wjones127
approved these changes
Nov 17, 2023
chebbyChefNEQ
force-pushed
the
rmeng/fix-index
branch
from
e264a21
to
c15f143
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make IVF partition calculation parallelize