chore: expose avx512fp16 feature via main lance crate #1626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lance-linalghas a feature flagavx512fp16, once enabled, it compiles thef16.cfor auto-vectorized routines forf16on CPUs withavx512fp16instruction set.This PR propagate the optional feature flag (avx512fp16) to the lance crate, so that we can build
avx512fp16from the main crate as well.Did not use
RUSTCFLAGS="-C target-feature=+avx512fp16" because rustc (1.74at the time of wriitng), does not pass this feature tobuild.rs` .