fix: prevent OOM when IVF centroids are provided #1653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjones127
commented
Nov 22, 2023
| for col in batch.column_names: | ||
| for col in batch.schema.names: |
There was a problem hiding this comment.
This is to support older versions of pyarrow. pyarrow 12.0.0 doesn't have RecordBatch.column_names. (For some reason that's the version conda solved for when I needed to install pytorch.)
Comment on lines
+634
to
+645
| let mut training_data = if ivf_params.centroids.is_none() { | ||
| let start = std::time::Instant::now(); | ||
| log::info!( | ||
| "Loading training data for IVF. Sample size: {}", | ||
| sample_size_hint | ||
| ); | ||
| let data = Some(maybe_sample_training_data(dataset, column, sample_size_hint).await?); | ||
| log::info!( | ||
| "Finished loading training data in {:02} seconds", | ||
| start.elapsed().as_secs_f32() | ||
| ); | ||
| data |
There was a problem hiding this comment.
nit: maybe just add the timer in maybe_sample_training_data?
There was a problem hiding this comment.
With the narrative logs, I like that they are all in 1 function. 🤷
chebbyChefNEQ
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are a small collection of fixes I needed in order to run a benchmark for partitioning while using CUDA acceleration.