Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add ruff copyright check #1716

Merged
merged 2 commits into from
Dec 13, 2023
Merged

chore: add ruff copyright check #1716

merged 2 commits into from
Dec 13, 2023

Conversation

eddyxu
Copy link
Contributor

@eddyxu eddyxu commented Dec 13, 2023

Add a ruff rule to enforce copyright header is presented in python files

Copy link
Contributor

@wjones127 wjones127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@wjones127
Copy link
Contributor

Looks like the mirror failed when installing system deps. Should be able to just retry the job?

@eddyxu
Copy link
Contributor Author

eddyxu commented Dec 13, 2023

Looks like the mirror failed when installing system deps. Should be able to just retry the job?

Lemme take a look. seems that protobuf is not installed.

@wjones127
Copy link
Contributor

@eddyxu It's just that it failed here:

https://github.com/lancedb/lance/actions/runs/7200989635/job/19616217571?pr=1716#step:5:313

The install command is here:

before-script-linux: |
yum install -y openssl-devel \
&& curl -L https://github.com/protocolbuffers/protobuf/releases/download/v21.12/protoc-21.12-linux-$(uname -m).zip > /tmp/protoc.zip \
&& unzip /tmp/protoc.zip -d /usr/local \
&& rm /tmp/protoc.zip

@eddyxu eddyxu merged commit dadc9dc into main Dec 13, 2023
12 checks passed
@eddyxu eddyxu deleted the lei/copyright branch December 13, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants